Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add functionName and actionApiIdentifier when sending stubbed action event #642

Merged
merged 1 commit into from
Sep 16, 2024
Merged

Add functionName and actionApiIdentifier when sending stubbed action event #642

merged 1 commit into from
Sep 16, 2024
+17 −9

Conversation

alanko0511
Copy link
Contributor

@alanko0511 alanko0511 commented Sep 13, 2024 •
edited
Loading

This fixes bug introduced in #638 where a wrong action API identifier being sent when it is a bulk action.

PR Checklist

  • Important or complicated code is tested
  • Any user facing changes are documented in the Gadget-side changelog
  • Any immediate changes are slated for release in Gadget via a generated package dependency bump
  • Versions within this monorepo are matching and there's a valid upgrade path

@alanko0511 alanko0511 marked this pull request as ready for review September 13, 2024 21:07
MillanWangGadget
MillanWangGadget approved these changes Sep 13, 2024
View reviewed changes
Copy link
Contributor

@MillanWangGadget MillanWangGadget left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well with related PR in Gadget main repo. functionName and actionApiIdentifier will only be different for bulk actions, and checking their equality seems like a reasonable way to tell if you're looking at a global action.

@alanko0511 alanko0511 merged commit 8fe1cf5 into main Sep 16, 2024
9 checks passed
@alanko0511 alanko0511 deleted the alan/fix-bulk-action-wrong-id branch September 16, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danroberts danroberts danroberts approved these changes

@MillanWangGadget MillanWangGadget MillanWangGadget approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alanko0511 @danroberts @MillanWangGadget